-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
14 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbad111
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keradus Hello!
Please consider uploading PHAR + .asc to shim releases and encourage users to use PHIVE.
https://github.com/phar-io/phive
cbad111
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait! Isn't shim's PHAR file the very same as the one attached to this release?
cbad111
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @szepeviktor ,
you commented on a commit, I strongly encourage to raise a discussion as github issue on main or shim repos.
To be honest, I don't understand your suggestion - phar and .asc files are part of the main repo github release, and phive is already using them (and we open the phive suggestion to users of Fixer - https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/master/doc/installation.rst#locally-phive ). We want to suggest using shim (but not via phive) as main installation method, but we are now in beta phase of it.
yes they are.
cbad111
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a phive advocate.
cbad111
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and we support that for you, you are welcome to use it ;)