Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a search button in the filter modal #6938

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

MilkyLane
Copy link

@MilkyLane MilkyLane commented Feb 27, 2025

Title

This adds the feature "apply button to search filters modal"

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

#6194

Closes: #6194

Description

Added a new function that uses the same openInternnalPath function used by main search, a button, and a gap for the new button improvements. Tested functionality using console logs and trial-and-error. No known issues.

Screenshots

image

Testing

Pull request tested

Tested using console logs and trial-and-error to verify functionality.

No ramifications remaining

Desktop

  • OS: Windows
  • OS Version: 10, Version 22H2
  • FreeTube version: v0.23.2 Beta

Additional context

No additional context.

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 27, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 27, 2025 13:21
@efb4f5ff-1298-471a-8973-3d47447115dc

see review comments on #6277 #6627 to improve your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: waiting for review For PRs that are complete, tested, and ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add apply button to search filters modal
2 participants