provisioning: Prevent re-provisioning #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urutva
previously approved these changes
Sep 27, 2024
|
|
||
| if( status != PSA_SUCCESS ) | ||
| /* FIXME: Magic value */ |
There was a problem hiding this comment.
Is this comment going to be addressed? I see it in each main.c.
There was a problem hiding this comment.
Removed the comment, we will fix this issue in the upcoming PRs.
|
|
||
| if( status != PSA_SUCCESS ) | ||
| { | ||
| return 0; |
There was a problem hiding this comment.
Minor comment - I notice in calls to this function you check if it returns "false" and not 0. Should this function return "false" and "true" ?
aggarg
previously approved these changes
Sep 30, 2024
After successful provisioning, the code writes a pattern into the ITS, which could be checked on the next boot. Signed-off-by: Dávid Házi <[email protected]>
david-hazi-arm
force-pushed
the
dev/davhaz01/provisioning_fix
branch
from
f7de2ad to
1740690
Compare
urutva
approved these changes
Oct 8, 2024
|
@jasonpcarroll Can you please re-review? Thanks |
aggarg
approved these changes
Oct 9, 2024
jasonpcarroll
approved these changes
Oct 9, 2024
|
@david-hazi-arm @urutva approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After successful provisioning, the code writes a pattern into the ITS, which could be checked on the next boot.
Description
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.