Fix AWS TLS Expired Server Cert test #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archigup
reviewed
Mar 1, 2024
| * can be a configuration used: | ||
| * | ||
| */ | ||
| #define democonfigLIST_OF_TIME_SERVERS "pool.ntp.org" |
There was a problem hiding this comment.
Should consider using time.aws.com
There was a problem hiding this comment.
@archigup The coreSNTP example was used as reference for this implementation. I think, it's a good idea to switch to time.aws.com. Are there any prerequisites for using time.aws.com?
There was a problem hiding this comment.
I've switched to use time.aws.com and it seems to be working without any modifications needed.
archigup
previously approved these changes
Mar 1, 2024
AhmedIsmail02
force-pushed
the
fix-aws-tls-expired-server-cert-test
branch
from
eafb9b8 to
4ecfe79
Compare
hugueskamba
approved these changes
Mar 4, 2024
AhmedIsmail02
force-pushed
the
fix-aws-tls-expired-server-cert-test
branch
from
4ecfe79 to
e7800bd
Compare
|
@archigup @chinglee-iot @aggarg |
Fix `descrived` typo. Signed-off-by: Dávid Házi <[email protected]>
Add latest LTS release of coreSNTP FreeRTOS library to the FRI to be used for synchronisng embedded targets clock time. Signed-off-by: Ahmed Ismail <[email protected]>
This helper library shall be used with any FRI application to add real clock time synchronisation for the target. This addition is needed to fix AWS TLS Expired Server Cert test which is part of AWS Device Advisor Validation tests as this test requires the device under test to have synchronised real time clock to be able to detect that the server's certificate is expired and reject it. Signed-off-by: Ahmed Ismail <[email protected]>
Add real clock time synchronisation to keyword-detection application by using `coresntp` and `helpers-time-sync` libraries This would require using MbedTLS time functions alternatives to query the correct synchronised real clock time. This addition would fix AWS TLS Expired Server Cert test as previously, wrong clock time was fetched which result in using expired server certificate. Now, correct clock time would be fetched which results in target rejecting the server's expired certificate which in turn fixes the test. Signed-off-by: Ahmed Ismail <[email protected]>
AhmedIsmail02
force-pushed
the
fix-aws-tls-expired-server-cert-test
branch
from
e7800bd to
166e211
Compare
urutva
approved these changes
Mar 11, 2024
amazonKamath
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the following:
Notes:
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.