Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_parseSignalQuality function does not compute RSSI #83

Closed
jpolonsky-tyc opened this issue Mar 3, 2022 · 3 comments
Closed

_parseSignalQuality function does not compute RSSI #83

jpolonsky-tyc opened this issue Mar 3, 2022 · 3 comments
Assignees

Comments

@jpolonsky-tyc
Copy link

In cellular_hl7802_api.c on line 1080, the function _parseSignalQuality calls _Cellular_ConvertCsqSignalRssi and passes the second argument as "berValue", whereas the function expects raw RSSI as "pRssiValue".
On line 1066, the first token (which is actually the RSSI value) is deliberately skipped.
In effect, it skips RSSI and miscalculates BER.

@jpolonsky-tyc
Copy link
Author

I have also noticed that the callback uses _Cellular_ConvertCsqSignalRssi which expects a response received from "AT+CSQ", while the command used for Cellular_GetSignalInfo is "AT+CESQ". The format of RSSI is different in those two messages.

@chinglee-iot
Copy link
Member

Hi Jpolonsky,

Sorry for late reply. We will look into the question and reply.

@chinglee-iot
Copy link
Member

@jpolonsky-tyc
This issue is fixed in this PR #84. Thank you for your feedback.

@chinglee-iot chinglee-iot self-assigned this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants