[improvement]: Rename opportunistic srtp to optimistic

[lgaetz]

FreePBX Version

FreePBX 17

Improvement Description

The Advanced tab for pjsip extension has the following parameter:

The parameter in the fbpx GUI is named "Opportunistic SRTP" but it controls the Asterisk pjsip parm, media_encryption_optimistic which is also noted in the gui tool tip.

I don't know where the word opportunistic came from, possibly it was carried over from chan_sip config, or perhaps it was a misunderstanding or autocorrect mistake from when PJSIP support was first added to fpbx. Curiously, the word opportunistic does not appear in the freepbx wiki, but where the setting is documented, the wiki refers to it as "Optimistic".
REF https://sangomakb.atlassian.net/wiki/spaces/PG/pages/22020636/Extensions+Module+-+PJSIP+Extension#Media-Encryption-Optimistic

In any case, I feel like the word "opportunistic" is a typo, and while not serious, can cause confusion if anyone goes looking for more help on the subject from Asterisk resources. I suggest that the parameter in the GUI be renamed to:

Allow Non-Encrypted Media (Optimistic SRTP)

[jcolp]

Opportunistic is the official RFC naming:

https://www.rfc-editor.org/rfc/rfc8643.html

The PJSIP implementation predates it and I used optimistic there.

[lgaetz]

How annoying.

There's a case to be made for using either term, and in fact fpbx uses both which is probably as clear as it can be. I don't see a strong reason to break gui translation strings, and thus withdraw my recommendation for the change.

I would suggest that the wiki page linked above be updated to include the word "opportunistic" to assist searches, and perhaps include a note indicating they are equivalent in the context of media encryption.