Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove version check #58

Closed
Rubberbandits opened this issue May 2, 2020 · 5 comments · Fixed by #59
Closed

Please remove version check #58

Rubberbandits opened this issue May 2, 2020 · 5 comments · Fixed by #59

Comments

@Rubberbandits
Copy link

The version check is nice, but at least add some way to disable it. Server hangs for up to two minutes on boot trying to check the version of the module.

@FredyH
Copy link
Owner

FredyH commented May 2, 2020

Why would the version check hang on boot? It should run asynchronously using gmods http library.

@Rubberbandits
Copy link
Author

im not entirely sure why it does but i think its because during boot, chromium isnt running async. i just know that once a player joins, the server hangs on the version check and ents think for like 55 seconds.

server resumes once the version check finishes

@viral32111
Copy link
Contributor

I've made a fork with the code changes for an optional version checker. It's simple to turn on or off, just add sv_mysqloo_versioncheck 0/1 to the server.cfg file or alike.

@Rubberbandits Can you try test this and see if it fixes your issue? If it does, I'll make a PR.

Download (I've only tested Windows 32-bit).

@FredyH
Copy link
Owner

FredyH commented May 2, 2020

@viral32111 Sounds good, feel free to make a PR and I'll look at it once I am back home

@Rubberbandits
Copy link
Author

the launch of our new gamemode is today, so it might not be tested until later tonight. will let you know, we're running ubuntu so we'll find out if the module works on linux32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants