Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[✨ feature] Issue detail page (event list) #74

Open
1 of 7 tasks
Fredkiss3 opened this issue Oct 1, 2023 · 0 comments
Open
1 of 7 tasks

[✨ feature] Issue detail page (event list) #74

Fredkiss3 opened this issue Oct 1, 2023 · 0 comments
Labels
feature New feature or request

Comments

@Fredkiss3
Copy link
Owner

Fredkiss3 commented Oct 1, 2023

Is your feature request related to a problem? Please describe.

This issue is for listing comments & other events on the issue page.

Describe the solution you'd like

  • Support listing comments
  • Listing other events in the supported list (see list for more info) :
    export const eventTypeEnum = pgEnum("event_type", [
    "CHANGE_TITLE",
    "TOGGLE_STATUS",
    "ISSUE_MENTION",
    "ASSIGN_USER",
    "ADD_LABEL",
    "REMOVE_LABEL",
    "ADD_COMMENT"
    ]);
  • Support Reporting comments
  • Support adding reaction to comment (unless connected) => can only add one type of reaction per user and highlight reactions already made by the current user
  • Page should be real time, listening to each events using partykit, example app 👉🏾 https://github.com/partykit/partypoll/
  • Should support linking and highlighting a comment, if a comment is hidden by default, we can load request it in the timeline

Additional context

  • Use infinite loading with virtualization, we can defer loading issues on the client with server actions that return comment components (these components should be async to not block rendering)
  • Github by default loads only 60 events, 30 at the start and 30 at the end, then the user has to load the rest in the middle after : can we do the same ? 🤔
  • When there is a new comment, the title shows the number of unread events, and when the user scrolls down to the comment, the title reverts back to normal, and the comment is highlighted for a brief second
  • Using websockets with React-Query

Additionnal actions :

image

Comment highlighting :

image
  • Are you willing to make a PR for this ?
@Fredkiss3 Fredkiss3 added the feature New feature or request label Oct 1, 2023
@Fredkiss3 Fredkiss3 added this to Gh-next Oct 1, 2023
@Fredkiss3 Fredkiss3 moved this to Todo in Gh-next Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant