Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executor class leaves processes running after cancellation #11

Closed
FrankD412 opened this issue Feb 23, 2021 · 2 comments
Closed

Executor class leaves processes running after cancellation #11

FrankD412 opened this issue Feb 23, 2021 · 2 comments
Assignees
@FrankD412
Labels
bug Something isn't working confirmed A confirmed bug

Comments

@FrankD412
Copy link
Owner

FrankD412 commented Feb 23, 2021 •
edited
Loading

When testing PR 345, the sample specification for LULESH using the LocalPoolAdapter leaves long-running processes when a cancellation is requested. It seems that the Executor class does not use the proper process kill to remove these processes.
@FrankD412 FrankD412 added bug Something isn't working confirmed A confirmed bug labels Feb 23, 2021
@FrankD412 FrankD412 self-assigned this Feb 23, 2021
@FrankD412
Copy link
Owner Author

After some time debugging, it looks as though the method Executor._Record.cancel was only terminating then killing the children. The missing call to terminate the parent made the assumption that the children would terminate and then be killed, but never touches the parent. That means the hard "eviction" of the process never happens.

@FrankD412
Copy link
Owner Author

Accidentally pushed to main.. Fixed by commit ac6cee92112ffa659ccf1016a71451022cb0b23c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrankD412 FrankD412

Labels
bug Something isn't working confirmed A confirmed bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FrankD412