Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight confusion with variable names #3

Open
AI-Guru opened this issue Nov 6, 2019 · 0 comments
Open

Slight confusion with variable names #3

AI-Guru opened this issue Nov 6, 2019 · 0 comments

Comments

@AI-Guru
Copy link

AI-Guru commented Nov 6, 2019

Hello!

First of all, I really like your approach. This is some very solid work! Congratulations.

I think I have found a slight discrepancy. Between lines
https://github.com/FrankCAN/GAPointNet/blob/master/models/network.py#L32
and
https://github.com/FrankCAN/GAPointNet/blob/master/models/gat_layers.py#L56

You see, attn_feature() returns "ret, coefs, edge_feature", while getmodel() unpacks the values as "edge_feature, coefs, locals". The order is slightly different. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant