Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate_PSNR_SSIM.m and Warning ignore of main code #17

Open
Davorking opened this issue Sep 21, 2023 · 0 comments
Open

Evaluate_PSNR_SSIM.m and Warning ignore of main code #17

Davorking opened this issue Sep 21, 2023 · 0 comments

Comments

@Davorking
Copy link

Davorking commented Sep 21, 2023

I've spotted some subtle issues that may need to be taken care of.

  1. Evaluate_PSNR_SSIM.m appears to be using ./HR directory for reading HR images in order to compute PSNR and SSIM value. However, according to the Readme, the correct directory actually should be ./benchmark/HR/.
    Line 34 and Line 41 should add an additional './benchmark' parameter to fullfile() function.

  2. The whole warning suppression module import and usage seems completely unnecessary, just change line 206 of ./ops/OSA.py to
    grid = torch.stack(torch.meshgrid(pos, pos, indexing="ij")) the warning would go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant