Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mp3 should be the automatic file extension type #6

Closed
RustoMCSpit opened this issue Dec 4, 2023 · 7 comments
Closed

mp3 should be the automatic file extension type #6

RustoMCSpit opened this issue Dec 4, 2023 · 7 comments
Labels
template missing The bug/feature template is missing

Comments

@RustoMCSpit
Copy link

RustoMCSpit commented Dec 4, 2023

Describe the solution you'd like
on first open of the app ask the user to input desired file extension and clarify that m4a isnt foss

Describe alternatives you've considered
just make mp3 the default until flac is integrated / opus is fixed

@Aga-C
Copy link
Member

Aga-C commented Dec 7, 2023

Please adjust your feature request report to the issue template.

@Aga-C Aga-C added enhancement New feature or request waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. template missing The bug/feature template is missing labels Dec 8, 2023
@Aga-C Aga-C added needs triage Issue is not yet ready for PR authors to take up and removed waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. labels Dec 19, 2023
@RustoMCSpit
Copy link
Author

RustoMCSpit commented Jan 1, 2024

whats needs triage mean?
edit: just looked it up, honestly this is such an easy fix that it doesnt 'need triage', i imagine youd just change a single variables initial state and it's done

@Aga-C
Copy link
Member

Aga-C commented Jan 1, 2024

This label means: Issue is not yet ready for PR authors to take up. We're waiting for the issue template to be filled out properly.

@RustoMCSpit
Copy link
Author

This label means: Issue is not yet ready for PR authors to take up. We're waiting for the issue template to be filled out properly.

thats pedantic but okay

@Aga-C Aga-C removed the template missing The bug/feature template is missing label Jan 1, 2024
@Aga-C
Copy link
Member

Aga-C commented Jan 1, 2024

@naveensingh Can you check this and decide whether it should be done?

@inson1
Copy link

inson1 commented Jan 2, 2024

@naveensingh
Copy link
Member

SimpleMobileTools/Simple-Voice-Recorder#1
SimpleMobileTools/Simple-Voice-Recorder#21
SimpleMobileTools/Simple-Voice-Recorder#62

Support for 'real' MP3 format was added in SimpleMobileTools/Simple-Voice-Recorder#114. I haven't done much work on the Voice Recorder but I think the M4A stayed the default because:

  • Tibor forgot to switch to MP3.
  • Or the MP3 recorder implementation wasn't reliable enough (I remember some chatter related to it)

So we will switch to MP3 but if it causes any problems among the uninitiated users, I'm switching it back to M4A until MP3 works properly.

honestly this is such an easy fix that it doesnt 'need triage', i imagine youd just change a single variables initial state and it's done

@RustoMCSpit it has nothing to do with easy. In projects like this, one must carefully consider the consequences before changing even a small constant. If we don't, it won't be long before the whole project is a mess that only works properly for a small group of people. When working with SMT, we often broke things even when we were sure we had considered every possible use case.

@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Jan 2, 2024
@naveensingh naveensingh added the template missing The bug/feature template is missing label Jan 8, 2024
@Aga-C Aga-C added the needs triage Issue is not yet ready for PR authors to take up label Jan 8, 2024
@Aga-C Aga-C closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2024
@Aga-C Aga-C removed enhancement New feature or request needs triage Issue is not yet ready for PR authors to take up labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template missing The bug/feature template is missing
Projects
None yet
Development

No branches or pull requests

4 participants