Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to replace original after edit #62

Open
5 tasks done
anon1892 opened this issue Jan 7, 2024 · 6 comments
Open
5 tasks done

Add an option to replace original after edit #62

anon1892 opened this issue Jan 7, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@anon1892
Copy link

anon1892 commented Jan 7, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Is your feature request related to a problem? Please describe.
When I edit a picture, for example crop it, a modal always ask the name of the new picture.
But I almost always want to replace the original picture, so I have to remove "_1" on the name, click OK, then a second modal warns me that it will replace an existing file. It's long!

Describe the solution you'd like
It would be nice if another button is implemented to replace directly the original file (maybe next to "Cancel" and "Ok" buttons of the first modal?)

@anon1892 anon1892 added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 7, 2024
@anon1892 anon1892 changed the title [FEATURE REQUEST] Add an option to replace original after edit Add an option to replace original after edit Jan 7, 2024
@Aga-C Aga-C added enhancement New feature or request and removed feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 7, 2024
@Aga-C
Copy link
Member

Aga-C commented Jan 7, 2024

In my opinion, another button would be misleading because it wouldn't make a sense that above it are inputs that are not considered in an action.

I think a better option would be if by default the dialog would contain only a checked checkbox/switch "Overwrite current file" (or something similar), and if someone unchecks the option, then the inputs (that currently are in the dialog) show.

@anon1892
Copy link
Author

anon1892 commented Jan 7, 2024

You're right, it would be even better.
But the checkbox needs to remain checked if the user check it (it should remember of the last time, checked or not)

@TechD123
Copy link

TechD123 commented Jan 29, 2024

I think a better option would be if by default the dialog would contain only a checked checkbox/switch "Overwrite current file" (or something similar), and if someone unchecks the option, then the inputs (that currently are in the dialog) show.

Exactly what I was going to ask for right now! The current editing UX is good, but the file name should be hid by abstraction as you explain.

We could go further and make saving edits even more seamless by not showing an extra dialog at all:

  • make it a persistent choice in settings (e.g. toggle: "Overwrite images after editing?" which is off by default to prevent unknowing users from deleting their original pictures)
  • when the user taps the checkmark at the end of editing, this setting is respected
  • however, when the user long presses on the checkmark, the dialog as explained above shows up, where the user can change his preference this once only and/or specify the file name

Therefore the default behavior ("Overwrite images after editing?" off) would be:

  • user finishes edit by tapping checkmark
  • the new, modified image is saved (ideally the editor would open this new image with the default gallery app)

This would only expose the user to an extra step when they want it.

@Saarsk
Copy link

Saarsk commented Sep 28, 2024

In my opinion, another button would be misleading because it wouldn't make a sense that above it are inputs that are not considered in an action.

I think a better option would be if by default the dialog would contain only a checked checkbox/switch "Overwrite current file" (or something similar), and if someone unchecks the option, then the inputs (that currently are in the dialog) show.

Hmm, I actually disagree. I don't think that extra tap (action) should be necessary. A single "save and overwrite" action should be possible as a single tap, imo.

If the save dialog just have a checkmark that could be confusing as well as most people tend to forget stuff like that and barely care to pay attention to text and options.

Having a third button, preferably with orange background or something, I think would be perfectly intuitive for regular folks as well, if implemented clear and concise.

I think that if you have to do extra actions on top of the actions required by opening the pop-up dialog, I think many people will just not bother and take the short route and just fill up their storage with unecessary edited copies.


Many people find it tedious just to do a screenshot in the first place. And even though I disagree with taking the lazy way out and just not do the thing that is tedious, I can still understand it. Tedium is stressful in this day and age and we need tools to be efficient and quick, in my opinion. People have so many tasks and things they do, even if it's just for recreation instead of work. I think our devices' capabilities are often held back by tedium and slow workflows. Even the most mundane tasks need efficiency.

So please consider a third button. It could optionally "save" the original in the trash bin (optionally for x amount of minutes, hours, days) in order to alleviate data loss concerns, if that is something people want (I don't, personally). To be fair, sometimes screenshots are important (proof of something you need for a support ticket, legal documentation etc.

@thisisartman
Copy link

thisisartman commented Oct 1, 2024

I think the way Google Photos phrases it is useful to consider too. Either a "Save as Copy" button, or a quick popup to confirm the action with relevant description of the action being taken.

Screenshot_20241001-121513.png Screenshot_20241001-121447.png Screenshot_20241001-121449.png

As for screenshots, I'd argue that nobody ever needs to retain the original unless chosen otherwise so having something like "Overwrite Original" is a valid way to work with it.

Anyhow, I trust you guys will do whatever feels most useful. 🫡 Anything that does not require me to confirm a new name for the file...

Screenshot_20241001-121851.png

is fine by me 😁.

@Saarsk
Copy link

Saarsk commented Oct 1, 2024

As for screenshots, I'd argue that nobody ever needs to retain the original unless chosen otherwise so having something like "Overwrite Original" is a valid way to work with it.

I do (regularly). ;) I regularly take a screenshot and make an edit (e.g. notes to me or recipient, or temporary crop for various reasons) while keeping the original (which I also need). 🙂 And I know I'm not the only one.

One should be careful about making assumptions about people's use-cases and needs. :) I think it's important to try to imagine how others might use the same app and from that broad perspective look at possible UI changes. 🙂

An app's UI shouldn't make such inhibiting assumptions and then be limited on that basis. It should intuitively, clearly and efficiently account for different possible use-cases. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants