Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better selection of backup location #101

Closed
6 of 7 tasks
mpldr opened this issue Jan 24, 2024 · 17 comments
Closed
6 of 7 tasks

Better selection of backup location #101

mpldr opened this issue Jan 24, 2024 · 17 comments
Labels
duplicate This issue or pull request already exists

Comments

@mpldr
Copy link

mpldr commented Jan 24, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

When selecting a backup-location it is not possible to just add an existing directory to the storage locations.

As an example, I want my Backups in /storage/emulated/0/Backups/Calendar/. /storage/emulated/0/Backups/ already exists. I now can't add the subdirectory, as I simply can not select it.

Why do you want this feature?

I am backing up my stuff with syncthing and, for this purpose, have the aptly named Backup directory, where all the backups are stored and then synchronised with my other devices.

Additional information

No response

@mpldr mpldr added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 24, 2024
@mpldr
Copy link
Author

mpldr commented Jan 24, 2024

This also affects the other apps, it's just that the calendar is where it is most urgent for me.

@Aga-C
Copy link
Member

Aga-C commented Jan 24, 2024

Actually, it seems to be a bug. I have no problem with adding a subdirectory and setting backup there. Can you add details about your phone model and OS version?

Please also check if you can do this in other paths, not managed by Syncthing.

@Aga-C Aga-C added bug Something is not working question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. and removed feature request Issue is about a new feature in the app labels Jan 24, 2024
@mpldr
Copy link
Author

mpldr commented Jan 24, 2024 via email

@github-actions github-actions bot removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Jan 24, 2024
@mpldr
Copy link
Author

mpldr commented Jan 24, 2024

Here's the promised screencast. Unfortunately too large for GitHub: https://0x0.st/HGpU.mp4

@Aga-C
Copy link
Member

Aga-C commented Jan 24, 2024

Thanks for sharing the screencast!

I have to admit, that's strange - I tested on two different phones (both with stock Android 13) and emulator (Android 14) and in this view I have this view, so I can select anything:

I suppose it may be related to GrapheneOS or custom ROMs in general. Can anybody else confirm this bug?

@Aga-C Aga-C added device/software specific Issues that only happen on some devices or with some specific hardware/software and removed question Further information is requested labels Jan 24, 2024
@mpldr
Copy link
Author

mpldr commented Jan 24, 2024

This might be related to some hardening done by Graphene… I'll poke around in the settings a bit.

@mpldr
Copy link
Author

mpldr commented Jan 24, 2024

Couldn't find anything I could toggle. Since one has to grant access manually anyways, why not just use the system prompt, though?

@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Jan 24, 2024
@naveensingh
Copy link
Member

naveensingh commented Jan 24, 2024

@mpldr
It does seem like a GrapheneOS security feature. Hopefully, other GrapheneOS users will confirm this. Normally, the app would be able to see the "Internal/Backups" directory but not its content.

Since one has to grant access manually anyways, why not just use the system prompt, though?

I agree. This needs to be reworked using SAF directly so the users can pick whatever directory they want.

In your particular case, as a workaround, I think you can tinker around with storage scopes to grant Fossify Calendar access to the Internal/Backups directory which was created by Syncthing. You can find more info at https://discuss.grapheneos.org/d/1935-how-do-i-enable-storage-scopes and https://grapheneos.org/usage#storage-scopes. If that doesn't work, then consider using another directory like Internal/Calendar until this is fixed.

@Aga-C Aga-C added the needs triage Issue is not yet ready for PR authors to take up label Jan 25, 2024
@min7-i
Copy link
Contributor

min7-i commented Jan 26, 2024

I tested it on GrapheneOS and I could select the following directories as a location for automatic backups: Internal\Download and Internal\Android\media. It was also possible to create new folders in those directories and in Internal.

However, I couldn't select any other existing directory.

I think you can tinker around with storage scopes to grant Fossify Calendar access to the Internal/Backups directory...

Storage Scopes can only be used when an app requests file permissions. As this is not the case with Fossify Calendar storage scopes are not available for this app in GrapheneOS.

@genodeftest
Copy link

Since this issue seems to be specific to GrapheneOS, how about adapting the title to include that information?

@mpldr
Copy link
Author

mpldr commented Feb 24, 2024

Since this issue seems to be specific to GrapheneOS, how about adapting the title to include that information?

While the specific issue that prompted the suggestion is specific to GrapheneOS, the suggestion itself very much isn't. I do think it would overall help very much with focussing development efforts to not maintain a file picker when one is already provided by the OS.

@mpldr
Copy link
Author

mpldr commented Feb 24, 2024

It might be an idea to move this issue to common though, as it also happens with the other apps.

@serrq
Copy link

serrq commented May 29, 2024

Your file picker doesn't see my other "volume" created with Anemo app.

Please turn to another file picker or repair this one.

@mpldr
Copy link
Author

mpldr commented May 29, 2024 via email

@serrq
Copy link

serrq commented May 29, 2024

Personally, I'd prefer using the one integrated into the system.

Yes, it is called SAF if I don't wrong.

@jm355
Copy link

jm355 commented Sep 24, 2024

I'm also running into this, it definitely seems ideal to simply use the system file picker

@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Sep 24, 2024
@Aga-C
Copy link
Member

Aga-C commented Oct 9, 2024

Closing in favor of general bug report for all apps: FossifyOrg/General-Discussion#211.

@Aga-C Aga-C closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2024
@Aga-C Aga-C added duplicate This issue or pull request already exists and removed device/software specific Issues that only happen on some devices or with some specific hardware/software bug Something is not working labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

7 participants