Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep filters when navigating between pages #93

Open
alexkosla opened this issue Mar 30, 2023 · 2 comments
Open

Keep filters when navigating between pages #93

alexkosla opened this issue Mar 30, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@alexkosla
Copy link

When going from a tab like "Overview", if you pick any/all of the filters (class, dates, format, etc.), the filters will disappear when switching to a new section like "Logs". I think by default it would be nice to have these filters carry over in local storage, as it's annoying to have to set stuff like the same dates on all of the pages.

@Forty-Bot
Copy link
Owner

Hm, I'm not sure about this. I've thought about implementing this in the past, but I was concerned about changing the defaults. We also don't currently have a way to clear filters, other than by navigating away from a page.

This doesn't require any local storage, as we already have the machinery in place to add filters to links to other pages. However, it might be nice to use cookies to store a preference here.

Before implementing this, I want to investigate what other sites (dotabuff, opendota, etc) do.

@Forty-Bot Forty-Bot added enhancement New feature or request good first issue Good for newcomers labels Mar 31, 2023
@Forty-Bot Forty-Bot changed the title Store Filters Locally for switching between tabs Keep filters when navigating between pages Mar 31, 2023
@Forty-Bot Forty-Bot removed the good first issue Good for newcomers label Jul 28, 2023
@Forty-Bot
Copy link
Owner

OK, so I saw this feature in Thunderbird. Effectively what they have is a button which you can select to keep filters when navigating between folders. I think that would work analogously with a checkbox. I think this would need to be implemented in javascript, since we want to make sure that you can check the box and then click a link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants