Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do updated logs work? #30

Closed
Forty-Bot opened this issue Jan 3, 2021 · 1 comment
Closed

How do updated logs work? #30

Forty-Bot opened this issue Jan 3, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Forty-Bot
Copy link
Owner

The current implementation assumes that logs are immutable, and are complete when first uploaded. However, logs.tf has a feature to update an existing log (which may? be used when e.g. a log is requested in the middle of a round). Since we poll for new logs every 5 minutes, we could be using stale data for some logs.

The proper response depends on the exact nature of how updating works:

  • If updated logs just get a new logid and redirect, then the existing deduplication process will catch them just fine.
  • If updated logs have their date updated when they are updated (but keep the same logid), then we can convert our inserts to upserts when the date is newer.
  • If the logs get silently updated, but the date is not changed, then we have a problem :)
@Forty-Bot Forty-Bot added bug Something isn't working enhancement New feature or request question Further information is requested and removed enhancement New feature or request labels Jan 3, 2021
@Forty-Bot Forty-Bot self-assigned this Jan 3, 2021
@Forty-Bot
Copy link
Owner Author

Ok, so as it turns out it is

If updated logs have their date updated when they are updated (but keep the same logid), then we can convert our inserts to upserts when the date is newer.

@Forty-Bot Forty-Bot removed the question Further information is requested label Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant