Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer icons.js for subsetting icons #121

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

jrjohnson
Copy link
Collaborator

Storing long lists of icons in environment.js results in very large meta
tags for the application. Since these have to be parsed before content
can be shown this can slow down the loading of boot animations that are
intended to load before the application is parsed.

Fixes #112

Storing long lists of icons in environment.js results in very large meta
tags for the application. Since these have to be parsed before content
can be shown this can slow down the loading of boot animations that are
intended to load before the application is parsed.
Copy link

@acorncom acorncom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Unless we should stick with the Ember standard of putting this config in ember-cli-build which is generally where build transforms go?

@jrjohnson
Copy link
Collaborator Author

@acorncom I'd prefer it there as well, but consolidated on ember-cli-build in #68 as getting build time options into the component where they are needed for determining the default icon set was too difficult for me to figure out.

@jrjohnson jrjohnson merged commit cec527a into FortAwesome:master Oct 31, 2019
@jrjohnson jrjohnson deleted the 112-prefer-icons.js branch October 31, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert configuration into ember-cli-build.js or use config/icons.js
2 participants