You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
This add-on uses config/environment.js for subsetting icons and other configuration in the application.
Reproducible test case
Subset icons using config/environment.js, then visit http://localhost:4200 and open the document, the meta tag named {{app}}/config/environment contains list of icons.
Expected behavior
The list of icons is not part of the runtime configuration, the list is provided by ember-cli-build.js or config/icons.js same as add-ons do.
Additional context
Using config/environment.js is not ideal for buildtime configuration like icon subsetting, because the list if icons is baked into the meta tag and served for every request.
The text was updated successfully, but these errors were encountered:
Describe the bug
This add-on uses
config/environment.js
for subsetting icons and other configuration in the application.Reproducible test case
Subset icons using
config/environment.js
, then visit http://localhost:4200 and open the document, themeta
tag named{{app}}/config/environment
contains list of icons.Expected behavior
The list of icons is not part of the runtime configuration, the list is provided by
ember-cli-build.js
orconfig/icons.js
same as add-ons do.Additional context
Using
config/environment.js
is not ideal for buildtime configuration like icon subsetting, because the list if icons is baked into the meta tag and served for every request.The text was updated successfully, but these errors were encountered: