Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert configuration into ember-cli-build.js or use config/icons.js #112

Closed
bobisjan opened this issue Aug 8, 2019 · 1 comment · Fixed by #121
Closed

Revert configuration into ember-cli-build.js or use config/icons.js #112

bobisjan opened this issue Aug 8, 2019 · 1 comment · Fixed by #121

Comments

@bobisjan
Copy link

bobisjan commented Aug 8, 2019

Describe the bug
This add-on uses config/environment.js for subsetting icons and other configuration in the application.

Reproducible test case
Subset icons using config/environment.js, then visit http://localhost:4200 and open the document, the meta tag named {{app}}/config/environment contains list of icons.

Expected behavior
The list of icons is not part of the runtime configuration, the list is provided by ember-cli-build.js or config/icons.js same as add-ons do.

Additional context
Using config/environment.js is not ideal for buildtime configuration like icon subsetting, because the list if icons is baked into the meta tag and served for every request.

@bobisjan
Copy link
Author

bobisjan commented Aug 8, 2019

FYI, using config/icons.js in application works fine 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant