Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(graphcache) - Fix unkeyable warnings for introspection results #779

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

kitten
Copy link
Member

@kitten kitten commented Apr 29, 2020

Summary

This fixes the typical Graphcache warnings for unkeyable entities to be muted for internal types, like __Type, which by convention start with double-underscores and are only used for any kind of introspection query.

Set of changes

  • Replace "Invalid key" warning check with regex pattern
  • Update regex pattern to include ^__

@kitten kitten requested a review from JoviDeCroock April 29, 2020 18:28
@changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2020

🦋 Changeset is good to go

Latest commit: 599c0a6

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@andyrichardson andyrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what this does but I trust you ❤️

@kitten kitten merged commit 45a74cd into master Apr 29, 2020
@kitten kitten deleted the fix/key-warning-for-introspection branch April 29, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants