(core) - Fix stringifyVariables (and thus operation keys) for Files

[kitten]

Resolve #649

Summary

When two operations with a File in the variables are sent the operation key would likely be the same since we never take any File attributes into account.

We'd hence like to have special handling for objects without any enumerable keys that also aren't plain objects.

Set of changes

• Add random (but stable) keying for objects without enumerable keys that aren't plain objects

[changeset-bot]

🦋 Changeset is good to go

Latest commit: 6ec3f62

We got this.

This PR includes changesets to release 1 package

Name	Type
@urql/core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[JoviDeCroock]

We could also add file.size to avoid the very unlikely scenario of these being equal but the solution in itself is awesome. Great work!

[gabor]

thanks for looking into this problem. i don't want to complicate things too much, but you can assign Blob objects too,probably, and those do not have names or modification-dates :-(

(as i explained in #649, i would prefer to just drop deduplication for mutations, but still, with this pull-requests, things will be more consistent, and that is a good thing)

[JoviDeCroock]

thanks for looking into this problem. i don't want to complicate things too much, but you can assign Blob objects too,probably, and those do not have names or modification-dates :-(

(as i explained in #649, i would prefer to just drop deduplication for mutations, but still, with this pull-requests, things will be more consistent, and that is a good thing)

Mutations aren't deduplicated it's a single stream of events, so the response is associated with an operationKey. We need a way to distinguish these things efficiently

[kitten]

We could likely just use ”[Blob ${size}]” for now?

[kitten]

Ok, we've found an alternative. Instead we now generate a random key for objects with non-enumerable keys that aren't "plain objects". So this should support File, Blob, and more