(feat) - promisified requests #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitten
reviewed
Aug 23, 2019
kitten
reviewed
Sep 6, 2019
kitten
approved these changes
Sep 6, 2019
kitten
reviewed
Sep 6, 2019
| take(1), | ||
| toPromise | ||
| ); | ||
| return source$ as PromisifiedSource<T>; |
There was a problem hiding this comment.
This cast shouldn't be necessary and it may be better to remove the any fallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #216
This is a POC with a minimal amount of added code to support this concept.
Wanted to give this a try, some concerns I'm having is what if we are polling? Multiple results will come in.
I would opt for no polling but yeah...
Been trying out some stuff but this does not seem to result in any responses during our tests
I've tried this in the examples and it works