Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) - remove useDevtoolsContext #387

Merged
merged 5 commits into from
Aug 21, 2019
Merged

Conversation

JoviDeCroock
Copy link
Collaborator

@JoviDeCroock JoviDeCroock commented Aug 13, 2019

Relies on publishing of: urql-graphql/urql-devtools-exchange#1

Removes 60gzipped bytes

@parkerziegler
Copy link
Contributor

Looks great to me @JoviDeCroock! Definitely merge ready once urql-graphql/urql-devtools-exchange#1 is published!

@andyrichardson
Copy link
Contributor

I've merged your changes in urql-devtools-exchange!

@andyrichardson
Copy link
Contributor

andyrichardson commented Aug 14, 2019

I think we should hold off merging this until the devtools exchange changes have been published - but this looks ready to merge 👍

@kitten
Copy link
Member

kitten commented Aug 14, 2019

@andyrichardson definitely 👍 otherwise we'd diverge and we don't want that confusion on master for sure

@JoviDeCroock JoviDeCroock force-pushed the chore/removeUseDevtoolsContext branch from 29b5665 to 220cd40 Compare August 20, 2019 13:37
@kitten kitten merged commit 666b799 into master Aug 21, 2019
@kitten kitten deleted the chore/removeUseDevtoolsContext branch August 21, 2019 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants