Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphcache): Refactor schema checks to be lazy #2640

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

kitten
Copy link
Member

@kitten kitten commented Aug 23, 2022

Tiny change to avoid creating a map eagerly for all types, fields, interfaces, and such too early, since some types may never end up being used, and some checks may end up never being run.

@kitten kitten requested a review from JoviDeCroock August 23, 2022 20:00
@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2022

🦋 Changeset detected

Latest commit: 619875f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@urql/exchange-graphcache Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kitten kitten merged commit 27f2c48 into main Aug 29, 2022
@kitten kitten deleted the feat/lazy-schema-checks branch August 29, 2022 22:31
@urql-ci urql-ci mentioned this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants