fix(graphcache): Switch fragment heuristic to always be truthy on writes #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we assumed that if an unknown fragment was being applied it'd be an exceptional case and would not have to apply if the cache doesn't already know all its fields. We can now (theoretically) safely switch to always return `true` on writes. When we encounter a field that isn't in the data, as returned by the API then we can eagerly write anyway and let it fail. This is important for cases where the fragment applies to an interface of a node rather than to a concrete type.
🦋 Changeset detectedLatest commit: 6aa01c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
May 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we assumed that if an unknown fragment was being applied it'd
be an exceptional case and would not have to apply if the cache doesn't
already know all its fields.
We can now (theoretically) safely switch to always return
trueon writes.When we encounter a field that isn't in the data, as returned by the API
then we can eagerly write anyway and let it fail.
This is safe because if we were to encounter
undefineddata, this signalsto the cache that the field should be deleted, which is correct.
This is important for cases where the fragment applies to an interface
of a node rather than to a concrete type.