Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(react) - diff data correctly for the next state computing #2238

Merged
merged 7 commits into from
Feb 2, 2022

Conversation

JoviDeCroock
Copy link
Collaborator

@JoviDeCroock JoviDeCroock commented Feb 2, 2022

Fixes #2236

Summary

Currently we just merge in with ...result which will override the data coming from the ...prevState with undefined for a small amount of time.

fixed repro

Set of changes

  • don't just spread in result, look at the data attribute individually

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2022

🦋 Changeset detected

Latest commit: 3a1eadc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
urql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoviDeCroock JoviDeCroock requested a review from kitten February 2, 2022 17:04
@JoviDeCroock JoviDeCroock marked this pull request as ready for review February 2, 2022 17:22
@JoviDeCroock JoviDeCroock merged commit 393912e into main Feb 2, 2022
@JoviDeCroock JoviDeCroock deleted the diff-prev-data branch February 2, 2022 18:19
@urql-ci urql-ci mentioned this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data undefined from useQuery when using pagination
2 participants