Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(graphcache) - improve perf by using String.indexOf in getField #1957

Merged
merged 5 commits into from
Sep 14, 2021

Conversation

JoviDeCroock
Copy link
Collaborator

@JoviDeCroock JoviDeCroock commented Sep 13, 2021

Summary

benchmark

Set of changes

  • remove regex and use indexOf

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2021

🦋 Changeset detected

Latest commit: 1a694fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@urql/exchange-graphcache Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoviDeCroock JoviDeCroock changed the title (graphcache) - improve perf by using String.indexOf in getField (graphcache) - improve perf by using String.startsWith in getField Sep 13, 2021
@JoviDeCroock JoviDeCroock changed the title (graphcache) - improve perf by using String.startsWith in getField (graphcache) - improve perf by using String.indexOf in getField Sep 13, 2021
@JoviDeCroock JoviDeCroock merged commit d3c452d into main Sep 14, 2021
@JoviDeCroock JoviDeCroock deleted the perf-improvement branch September 14, 2021 16:41
@urql-ci urql-ci mentioned this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants