-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(graphcache) - Increase structural (deep) equality in normalized query results #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 10feac2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
We can reduce the overhead of copying the original piece of data, which when a previous result is passed happens at least once, by eagerly writing the data to the object and swapping it out once it's needed
We've released initial prerelease versions:
This will automatically enable this PR's patch. |
JoviDeCroock
approved these changes
Aug 16, 2021
Merged
kitten
added a commit
that referenced
this pull request
Aug 17, 2021
kitten
added a commit
that referenced
this pull request
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1860
Summary
This change enables Graphcache to compare new query results (from its normalized cache) with previous query results. While we previously had some remaining logic to reuse field values for mutations, we now extended the concept to queries as well. Graphcache will query each field and check whether it has changed, only creating new objects when a selection set has actually changed. This creates structural / deep referential equality in more parts of the query as it changes and potentially helps UI frameworks (e.g. React with
useMemo
andReact.memo
) to avoid more work.In testing, I've noticed that currently (this isn't super optimized yet) this sacrifices about -10% of performance compared to the
main
branch. However, given that rendering may be much more expensive than querying our normalized cache we currently even deem this worth it. For typical queries we'd expect to see performance drop from an order of 20K operations per second to 18K, which means this won't be noticeable in typical use, but help development a lot.I've checked the minzipped change of sizes (
$ cat exchanges/graphcache/dist/*.min.mjs | gzip-size
) and am seeing a change from9.38kB
to9.61kB
, a delta of230B
.Set of changes
cacheExchange
query
operationsquery
operations (e.g.readSelection
) to reuse references as much as possible