(request-policy) - Fix requestPolicyExchange usage with persisted caching #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not set the TTL unless cache outcome is "miss". If the first result to come through the requestPolicyExchange was a cache-hit then the ttl was incorrectly set initially based on this cache hit and no network request was made. This happens when using persisted caching with the graphcache exchange since the very first result can be a cache hit. urql-graphql#1644
🦋 Changeset detectedLatest commit: 3be3427 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Mookiies
changed the title
Mookiies
changed the title
kitten
approved these changes
Jun 30, 2021
kitten
changed the title
JoviDeCroock
approved these changes
Jul 1, 2021
|
Awesome, thank you for the contribution! 🎉 this will now go into a version packages PR and when it's merged the publish will happen |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1644
Set of changes
Do not set the TTL unless cache outcome is "miss". If the first result to come through the requestPolicyExchange was a cache-hit then the ttl was set initially based on this cache hit and no network request was made. This happens when using
persisted caching with the graphcache exchange since the very first result could be a cache hit.