Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(graphcache) - apply bivarianceHack for type-generated graphCache configs #1687

Merged
merged 5 commits into from
Jun 23, 2021

Conversation

JoviDeCroock
Copy link
Collaborator

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2021

🦋 Changeset detected

Latest commit: 89dd8a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@urql/exchange-graphcache Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoviDeCroock JoviDeCroock changed the title (graphcahce) - create test highlighting the issue with generics (graphcache) - create test highlighting the issue with generics May 31, 2021

export interface ResolverConfig {
> = {
bivarianceHack(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this ever show up in error Output? If so that could be a really awkward type trace at times 😅

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to 😅

@JoviDeCroock JoviDeCroock marked this pull request as ready for review June 21, 2021 10:14
@JoviDeCroock JoviDeCroock changed the title (graphcache) - create test highlighting the issue with generics (graphcache) - apply bivarianceHack for type-generated graphCache configs Jun 23, 2021
@JoviDeCroock JoviDeCroock merged commit f4266f2 into main Jun 23, 2021
@JoviDeCroock JoviDeCroock deleted the types-tests branch June 23, 2021 13:37
@urql-ci urql-ci mentioned this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants