Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(graphcache) - add the ENTRIES_STORE_NAME to the clear transaction #1685

Merged
merged 2 commits into from
May 31, 2021

Conversation

JoviDeCroock
Copy link
Collaborator

Summary

We were clearing on ENTRIES_STORE_NAME without an active transaction. Fixes #1684

Set of changes

  • add ENTRIES_STORE_NAME to storage.clear() transaction

@JoviDeCroock JoviDeCroock requested a review from kitten May 31, 2021 14:12
@changeset-bot
Copy link

changeset-bot bot commented May 31, 2021

🦋 Changeset detected

Latest commit: 3f5f661

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@urql/exchange-graphcache Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoviDeCroock JoviDeCroock changed the title (graphcahce) - add the ENTRIES_STORE_NAME to the clear transaction (graphcache) - add the ENTRIES_STORE_NAME to the clear transaction May 31, 2021
Copy link
Member

@kitten kitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow! Nice catch

@JoviDeCroock JoviDeCroock merged commit f5e0b88 into main May 31, 2021
@JoviDeCroock JoviDeCroock deleted the correct-transaction branch May 31, 2021 14:22
@urql-ci urql-ci mentioned this pull request May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defaultStorage.clear() errors
2 participants