(react) - Fix Suspense-on-update giving stale results in Concurrent Mode #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 06d9080 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
force-pushed
the
fix/react-suspense-effects
branch
from
68efc84 to
c3d4585
Compare
After Suspense is triggered on an update all state is preserved and effects stay active (which we're already relying on to preserve the scanned state of the query hook). So we can also keep the suspense source active.
kitten
force-pushed
the
fix/react-suspense-effects
branch
from
432634d to
b2969f8
Compare
kitten
changed the title
JoviDeCroock
approved these changes
Jan 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1303
Summary
Fix edge cases related to Suspense triggering on an update in Concurrent Mode. Previously it was possible for stale state to be preserved across the Suspense update instead of the new state showing up. This has been fixed by preventing the suspending query source from closing prematurely.
See CodeSandbox for reproduction / fix in action: https://codesandbox.io/s/optimistic-andras-f2j1q?file=/src/useQuery.ts
For some next steps it'd be interesting to explore ways to remove the
toSuspenseSourcecache inuseQueryfor another solution that's more in-line with per-client shortterm caches, e.g. https://github.com/FormidableLabs/urql/tree/refactor/shared-sourcesSet of changes
toSuspenseSourcesources prematurely when throwing suspense promisetoSuspenseSourcefrom being sent without a priorPulleventuseSourcewhen the initial state getter throws a suspense promise