(graphcache) - Refactor SelectionIterator and clean up exports #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In theory these undocumented APIs could be used to write a custom normalized cache based on Graphcache's internal logic. However, we forgot to expose `initDataState` anyway and additionally these APIs were not actually in use by anyone. So for now we'll remove them.
- Replace object with just an iterate function - Reduce cost of iteration by adding recursive iterators
🦋 Changeset detectedLatest commit: 96a797d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These changes were initially started to remove obsolete exports from Graphcache. Previously we would expose some
data.tsinternals so they could be used externally, but since we forgot to exposeinitDataStatethose exports wouldn't be of much use anyway. So instead we can reduce our exports to a minimum just to satisfy ourbenchmark's needs.Also this made me search for some more bundlesize opportunities, and I found that a small
traversalhelper could be rewritten and the sharedSelectionIteratorcould be optimised a little. This also gave us a small micro-benchmark performance bump, since it's a hotpath.Set of changes
noopDataState,writeOptimistic, andreserveLayerfrom exportsgetFragmentsutility inast/traversal.tsmakeSelectionIteratorto become nested if needed and remove intermediary iterator object