This repository has been archived by the owner on Jul 6, 2020. It is now read-only.
Skip writing undefined fields and warn in dev #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit a case where an
undefined
value was written to the cache which lead to an incomplete query. This will most likely occur with invalidupdateQuery
calls or invalid optimistic results that includeundefined
fields, where the query expects a value.We now skip writing these fields and instead warn about them. It should never be acceptable to write
undefined
to the cache, as we only want to writenull
. In rare casesundefined
will indeed be written to remove records, but that's done with the explicitstore.removeRecord
call.We're indeed seeing some warnings for this case in the
write.test.ts
tests, but I'm pretty sure those were expected before.