This repository has been archived by the owner on Jul 6, 2020. It is now read-only.
Fix operation being referred to but undefined #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an interesting issue. We thought it was impossible to be referring to the same operation twice, since we're deduplicating for the operation key when processing dependencies. What we're not accounting for is that the operation may have been reexecuted by another write to the cache. This may happen in the following condition: - A result comes back and a write operation is performed. Dependencies are stored as usual - Another result comes back and triggers dependencies to be processed, which deletes some of the previous dependencies - Meanwhile a potential third write starts which expects to see a deleted dependency, but it has already been reexecute by the second write operation.
JoviDeCroock
approved these changes
Sep 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #69
This PR shall be known as the "Concurrency is Hard"-PR
This is an interesting issue.
We thought it was impossible to be referring to the same
operation twice, since we're deduplicating for the operation
key when processing dependencies.
What we're not accounting for is that the operation may have
been reexecuted by another write to the cache.
This may happen in the following condition:
are stored as usual
which deletes some of the previous dependencies
deleted dependency, but it has already been reexecute by the second
write operation.