This repository has been archived by the owner on Jul 6, 2020. It is now read-only.
(chore) - dev warnings #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, this also introduces limiting an error will be identified and globally kept. This way we won't spam the user with errors of the same query happening twice/more
kitten
reviewed
Sep 6, 2019
…e caching layer away
kitten
reviewed
Sep 6, 2019
src/helpers/warning.ts
Outdated
| @@ -0,0 +1,10 @@ | |||
| import w from 'warning'; | |||
There was a problem hiding this comment.
I know this is maybe out of scope for this PR but given that we completely scope warnings not to be in production, we can probably just log ourselves here and get rid of the dependency
There was a problem hiding this comment.
I don't mind replacing the w with console.error or console.warn if you want. The current behaviour of warning is to call error
kitten
approved these changes
Sep 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds selectionSet validation when we have a schema available…, this also introduces limiting an error will be identified and globally kept. This way we won't spam the user with errors of the same query happening twice/more