Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Enable resolvers to cause cache misses by returning undefined #143

Merged
merged 3 commits into from
Dec 19, 2019
Merged

Enable resolvers to cause cache misses by returning undefined #143

merged 3 commits into from
Dec 19, 2019

Conversation

kitten
Copy link
Member

@kitten kitten commented Dec 19, 2019 •
edited
Loading

Fix #110

@kitten kitten requested a review from JoviDeCroock December 19, 2019 15:37
JoviDeCroock
JoviDeCroock approved these changes Dec 19, 2019
View reviewed changes
Copy link

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the simplePagination fix right? Maybe we should add a test for that

@kitten kitten force-pushed the fix/schemaless-resolver-cache-miss branch from 449bf02 to 73d4012 Compare December 19, 2019 15:49
@kitten kitten requested a review from JoviDeCroock December 19, 2019 15:55
@kitten kitten merged commit 359ab25 into master Dec 19, 2019
@kitten kitten deleted the fix/schemaless-resolver-cache-miss branch December 19, 2019 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support simplePagination cases as automatic resolver with cache misses supported
2 participants
@kitten @JoviDeCroock