Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Add per-field deletion for persistence batch during GC #138

Merged
merged 7 commits into from
Dec 16, 2019
Merged

Add per-field deletion for persistence batch during GC #138

merged 7 commits into from
Dec 16, 2019

Conversation

kitten
Copy link
Member

@kitten kitten commented Dec 14, 2019 •
edited
Loading

  • Add per-field deletion during GC on persistence batch
  • Move to data.persistenceBatch
  • Prevent deferred storage.write from being scheduled twice
v2.0.0 master before persistence (#134) master after persistence This PR
6.85kB 6.68kB 6.94kB 7kB

@kitten kitten requested a review from JoviDeCroock December 14, 2019 13:34
@kitten kitten force-pushed the chore/batched-gc-persistence branch from 44d947e to 1fb64bf Compare December 14, 2019 20:16
JoviDeCroock
JoviDeCroock approved these changes Dec 15, 2019
View reviewed changes
Copy link

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, yeah I seem to have overlooked double scheduling 👍

src/store/store.test.ts Outdated Show resolved Hide resolved
@kitten kitten merged commit 797bc64 into master Dec 16, 2019
@kitten kitten mentioned this pull request Dec 20, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitten @JoviDeCroock