This repository has been archived by the owner on Jul 6, 2020. It is now read-only.
persistant layer for graphcache #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
commented
Dec 14, 2019
kitten
reviewed
Dec 14, 2019
kitten
approved these changes
Dec 14, 2019
src/cacheExchange.ts
Outdated
| let hydration: void | Promise<void>; | ||
| if (opts.storage) { | ||
| hydration = opts.storage.read().then(data => { | ||
| store.hydrateData(data, (opts as any).storage); |
There was a problem hiding this comment.
Typescript being weird.... It's saying .storage is possibly undefined....
There was a problem hiding this comment.
Seems to be because storage isn’t reassigned. Maybe we can try opts.storage!?
There was a problem hiding this comment.
This works.... opts!.storage!
EDIT: moving to a var works better
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changing a lot of internals I found that making this implementation again gave profit, it's smaller 🎉
This PR adds the ability to supply two async functions to the cache, these will function as an adapter for the persistence layer of your choice.
--> will for instance write to an indexedDb and read from it, first time you start the cache it will buffer every incoming operation until the store has been hydrated by the data from your persistence layer.
During gc we perform
set(key, undefined)on garbage collected fields/links to avoid our offline storage from heaping up.This is a first-step to a fully offline-compatible cache