This repository has been archived by the owner on Jul 6, 2020. It is now read-only.
Reduce size impact of populateExchange #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor some parts to avoid unnecessary immutability for micro-perf optimisations, and reduce size where possible by reusing helpers and swapping out immutability for mutability. Total minzipped size: 8.24kB -> 8.19kB
This isn't supported in IE11 and hence breaks compatibility if it isn't user polyfilled. See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/from
JoviDeCroock
approved these changes
Dec 3, 2019
Removes additional closures that aren't needed. Addresses PR comments
kitten
force-pushed
the
chore/reduce-populate-size
branch
from
a1e8efe to
abfd97a
Compare
kitten
force-pushed
the
chore/reduce-populate-size
branch
from
533ddaa to
b76cce9
Compare
| userFragments, | ||
| }: AddFragmentsToQuery) => { | ||
| export const addFragmentsToQuery = ( | ||
| schema: GraphQLSchema, |
There was a problem hiding this comment.
Is there an advantage to changing these to indexed parameters? It's less transparent as to what the arguments should be.
There was a problem hiding this comment.
It gets rid of the property names in the output JS (although I'd love if Terser would do that automatically)
I personally think it's still transparent since TS typehints (of the TS language server for instance) still give you the signature with names and types.
kitten
force-pushed
the
chore/reduce-populate-size
branch
from
809e7a3 to
cc633a0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
populateExchangeby reusing more helpers we already hadArray.fromfor IE11 compatTests are still passing. 💯
5.73kB6.62kB6.6kB