Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add page-action icon to Firefox #89

Closed
andyrichardson opened this issue Dec 13, 2019 · 2 comments
Closed

Add page-action icon to Firefox #89

andyrichardson opened this issue Dec 13, 2019 · 2 comments
Labels
Feature New feature or request Firefox Firefox specific Good first issue Ideal for new contributors

Comments

@andyrichardson
Copy link
Collaborator

The status icon in Chrome which shows when devtools is available or not does not show in Firefox.

See #36 for more detail on what the icon does.
@andyrichardson andyrichardson added Feature New feature or request Firefox Firefox specific labels Dec 13, 2019
@andyrichardson andyrichardson added the Good first issue Ideal for new contributors label May 19, 2020
@r281GQ
Copy link
Contributor

r281GQ commented Nov 2, 2020

That seems to be working for me.

This is a route in an app that does not have urql as a HOC.

route wo urql

And here is a route that has, icon not greyed out.

route w urql

The other icon there was just an experiment with pageAction API to see how chrome and firefox API differs.

@andyrichardson
Copy link
Collaborator Author

@r281GQ thanks for checking this - I'll close it in that case 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New feature or request Firefox Firefox specific Good first issue Ideal for new contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andyrichardson @r281GQ