Fix #122 and #123 #124
Merged
Fix #122 and #123 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkerziegler
approved these changes
Nov 8, 2019
There was a problem hiding this comment.
Thanks @gugahoa, this'll go out in 1.2.1. It seems like we'll want to migrate our devDependency to latest bs-platform as well. I'm also seeing a few warnings about shadowed constructors since we have a few similar variant constructor names, so I'll follow up on those soon as well. Thanks as always for contributing ❤️
This was referenced Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to use
reason-urqlin projects which usesbs-platform6.2.1