Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bs-platform to 5.2.1. Upgrade dependencies to fix security warnings. #116

Merged
merged 2 commits into from
Oct 29, 2019

Conversation

parkerziegler
Copy link
Contributor

This PR beings the process of migrating to v1.2.0 of urql! v1.2.0 has very little different when it comes to the bindings itself – the devtools features introduced in that release were later moved into the devtools exchange here: https://github.com/FormidableLabs/urql-devtools-exchange. For that reason, I don't see much point in writing those bindings for this release. Instead, I think we'll want to create bs-urql-devtools-exchange and use that for future releases. If others feel differently please let me know!

The vast majority of changes in this PR are just upgrading depedencies to fix some security warnings and sprucing up some of the examples both code-wise and UI-wise. I'll do a deeper dive into the 1.2.0 release of urql to see if there are any other features we're missing and schedule some time to get this out later this week!

cc/ @Schmavery @gugahoa

Copy link
Contributor

@gugahoa gugahoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I couldn't do a in-depth review as I'm really busy this past few weeks :^(
I'll upgrade as soon as it's released and test it in production, the best place to find bugs :)

@parkerziegler
Copy link
Contributor Author

parkerziegler commented Oct 29, 2019

No worries, thanks for taking a quick peak @gugahoa. I'll cut a release tomorrow! I did end up adding the operationDebugMeta information to the operationContext on the client, since it is technically a part of urql 1.2.0. I think I got everything else of note as well, so we'll test in production and I can cut patch releases if folks find issues.

@parkerziegler parkerziegler merged commit d31d0e5 into master Oct 29, 2019
@parkerziegler parkerziegler deleted the task/upgrade-bs-platform-security-warnings branch October 29, 2019 04:46
@parkerziegler
Copy link
Contributor Author

Released in v1.2.0 🎉 : https://github.com/FormidableLabs/reason-urql/releases/tag/v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants