Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx capitalization in CombinedError bindings #108

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

Schmavery
Copy link
Collaborator

Right now this is always null, since we don't match https://github.com/FormidableLabs/urql/blob/f4b11379e43ef14bbc2a5bf563a6aa2cc09b4271/src/utils/error.ts#L43

Probably we should also update graphqlErrors in the record to match, but since that's a breaking change, I thought it might be best done as part of something in #106?

@parkerziegler
Copy link
Contributor

Thanks @Schmavery, good catch! Yep, I'll have some updates for #106 b/t today and tomorrow sometime, so I'm thinking we'll release this plus those changes in a new minor version (since, as you point out, these are all breaking changes). Does that sound good to you?

@parkerziegler parkerziegler merged commit 234f063 into teamwalnut:master Oct 1, 2019
@Schmavery
Copy link
Collaborator Author

Sounds good. Your call if you wanna do breaking changes in a minor version, doesn't affect my usage too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants