Make bs-fetch a peerDependency. #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gugahoa
approved these changes
Sep 24, 2019
|
Sweet, glad it worked @gugahoa! Looks like the build just passed. I'll get this merged and publish v1.0.1 with this change. Thanks! |
|
Released in v1.0.1. |
This was referenced Oct 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to make
bs-fetchapeerDependencyforreason-urql.bs-fetchis solely used to type a few fields on theClientand thecombinedError, but otherwise isn't actually used. It needs to be there to support the compiler in these modules, but in order to prevent our dep from conflicting with a user's own version ofbs-fetch, we don't want to actually ship our dependency onbs-fetch.cc/ @gugahoa I haven't yet ported this over to the examples, but let me know if you're able to apply this patch to see if it can help fix your issues! I think it'd be a win for the lib overall if we could remove this dependency. Will follow up on the examples tomorrow, just a bit late here in London!