Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(smart-action): handle isReadOnly field in smart action forms #671

Merged
merged 4 commits into from
Apr 12, 2021
Merged

feat(smart-action): handle isReadOnly field in smart action forms #671

merged 4 commits into from
Apr 12, 2021

Conversation

GuillaumeCisco
Copy link
Contributor

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

@GuillaumeCisco GuillaumeCisco force-pushed the feat-smart-action-readOnly-field branch 2 times, most recently from f59915f to 8b21935 Compare March 26, 2021 10:33
@GuillaumeCisco GuillaumeCisco changed the title feat(smart-action): handle readOnly field feat(smart-action): handle disabled field Mar 26, 2021
@forest-bot
Copy link
Member

Task linked: CU-dk4zcr Smart Actions - Developers can display record's information as read only in a form

@GuillaumeCisco GuillaumeCisco marked this pull request as ready for review March 30, 2021 08:13
@GuillaumeCisco GuillaumeCisco force-pushed the feat-smart-action-readOnly-field branch from 4074a1e to 319dd3a Compare April 8, 2021 08:51
@GuillaumeCisco GuillaumeCisco changed the title feat(smart-action): handle disabled field feat(smart-action): handle isReadOnly field Apr 8, 2021
jeffladiray
jeffladiray previously approved these changes Apr 8, 2021
View reviewed changes
@jeffladiray jeffladiray self-requested a review April 8, 2021 13:56
@GuillaumeCisco GuillaumeCisco force-pushed the feat-smart-action-readOnly-field branch from 9e79918 to db8014d Compare April 8, 2021 13:56
jeffladiray
jeffladiray approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@jeffladiray jeffladiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to update your commit message though (More customer oriented).
Otherwise LGTM

@codeclimate
Copy link

codeclimate bot commented Apr 8, 2021

Code Climate has analyzed commit db8014d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (60% is the threshold).

This pull request will bring the total coverage in the repository to 54.8%.

View more on Code Climate.

@jeffladiray jeffladiray changed the title feat(smart-action): handle isReadOnly field feat(smart-action): support isReadOnly in smart actions forms Apr 12, 2021
@jeffladiray jeffladiray changed the title feat(smart-action): support isReadOnly in smart actions forms feat(smart-action): handle isReadOnly field in smart action forms Apr 12, 2021
@jeffladiray jeffladiray merged commit 4de9540 into master Apr 12, 2021
@jeffladiray jeffladiray deleted the feat-smart-action-readOnly-field branch April 12, 2021 12:36
forest-bot added a commit that referenced this pull request Apr 12, 2021
@forest-bot
chore(release): 8.3.0 [skip ci]
d084e6f 
# [8.3.0](v8.2.0...v8.3.0) (2021-04-12)

### Features

* **smart-action:** handle isReadOnly field in smart action forms ([#671](#671)) ([4de9540](4de9540))
@forest-bot
Copy link
Member

🎉 This PR is included in version 8.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ShohanRahman pushed a commit that referenced this pull request Jan 25, 2022
@arnaudbesnier
fix(security): patch y18n dependency vulnerabilities (#671)
884a400
ShohanRahman pushed a commit that referenced this pull request Jan 25, 2022
@forest-bot
chore(release): 7.3.4 [skip ci]
41a0b59 
## [7.3.4](ForestAdmin/forest-express-sequelize@v7.3.3...v7.3.4) (2021-04-01)

### Bug Fixes

* **security:** patch y18n dependency vulnerabilities ([#671](ForestAdmin/forest-express-sequelize#671)) ([884a400](ForestAdmin/forest-express-sequelize@884a400))
ShohanRahman pushed a commit that referenced this pull request Jan 25, 2022
@forest-bot
chore(release): 8.0.0-beta.2 [skip ci]
ca96548 
# [8.0.0-beta.2](ForestAdmin/forest-express-sequelize@v8.0.0-beta.1...v8.0.0-beta.2) (2021-04-16)

### Bug Fixes

* **date-filter:** filtering only on hours now returns the expected records ([#684](ForestAdmin/forest-express-sequelize#684)) ([135ac47](ForestAdmin/forest-express-sequelize@135ac47))
* **security:** patch forest-express transitive vulnerabilities ([#672](ForestAdmin/forest-express-sequelize#672)) ([e5135d2](ForestAdmin/forest-express-sequelize@e5135d2))
* **security:** patch ini dependency vulnérability ([#670](ForestAdmin/forest-express-sequelize#670)) ([3eb0958](ForestAdmin/forest-express-sequelize@3eb0958))
* **security:** patch marked dependency vulnerabilities ([#674](ForestAdmin/forest-express-sequelize#674)) ([5331694](ForestAdmin/forest-express-sequelize@5331694))
* **security:** patch node-notifier vulnerabilities ([#669](ForestAdmin/forest-express-sequelize#669)) ([a54b944](ForestAdmin/forest-express-sequelize@a54b944))
* **security:** patch y18n dependency vulnerabilities ([#671](ForestAdmin/forest-express-sequelize#671)) ([884a400](ForestAdmin/forest-express-sequelize@884a400))

### Features

* expose utils to parse filters ([#683](ForestAdmin/forest-express-sequelize#683)) ([4333529](ForestAdmin/forest-express-sequelize@4333529))
* **smart-action:** handle isReadOnly field in smart action forms ([#680](ForestAdmin/forest-express-sequelize#680)) ([18dd191](ForestAdmin/forest-express-sequelize@18dd191))
* **smart-action:** support hooks for smart collection ([#679](ForestAdmin/forest-express-sequelize#679)) ([5d80f8a](ForestAdmin/forest-express-sequelize@5d80f8a))
ShohanRahman pushed a commit that referenced this pull request Jan 25, 2022
@forest-bot @SteveBunlon
chore(release): 8.0.0-beta.2 [skip ci]
9401cd0 
# [8.0.0-beta.2](ForestAdmin/forest-express-sequelize@v8.0.0-beta.1...v8.0.0-beta.2) (2021-04-16)

### Bug Fixes

* **date-filter:** filtering only on hours now returns the expected records ([#684](ForestAdmin/forest-express-sequelize#684)) ([135ac47](ForestAdmin/forest-express-sequelize@135ac47))
* **security:** patch forest-express transitive vulnerabilities ([#672](ForestAdmin/forest-express-sequelize#672)) ([e5135d2](ForestAdmin/forest-express-sequelize@e5135d2))
* **security:** patch ini dependency vulnérability ([#670](ForestAdmin/forest-express-sequelize#670)) ([3eb0958](ForestAdmin/forest-express-sequelize@3eb0958))
* **security:** patch marked dependency vulnerabilities ([#674](ForestAdmin/forest-express-sequelize#674)) ([5331694](ForestAdmin/forest-express-sequelize@5331694))
* **security:** patch node-notifier vulnerabilities ([#669](ForestAdmin/forest-express-sequelize#669)) ([a54b944](ForestAdmin/forest-express-sequelize@a54b944))
* **security:** patch y18n dependency vulnerabilities ([#671](ForestAdmin/forest-express-sequelize#671)) ([884a400](ForestAdmin/forest-express-sequelize@884a400))

### Features

* expose utils to parse filters ([#683](ForestAdmin/forest-express-sequelize#683)) ([4333529](ForestAdmin/forest-express-sequelize@4333529))
* **smart-action:** handle isReadOnly field in smart action forms ([#680](ForestAdmin/forest-express-sequelize#680)) ([18dd191](ForestAdmin/forest-express-sequelize@18dd191))
* **smart-action:** support hooks for smart collection ([#679](ForestAdmin/forest-express-sequelize#679)) ([5d80f8a](ForestAdmin/forest-express-sequelize@5d80f8a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffladiray jeffladiray jeffladiray approved these changes

Assignees

@GuillaumeCisco GuillaumeCisco

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumeCisco @forest-bot @jeffladiray