Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authentication): return better errors when a user is not authorized to access a rendering #660

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

ghusse
Copy link
Contributor

@ghusse ghusse commented Mar 3, 2021

Linked to CU-f13259

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

…ed to access a rendering

Linked to CU-f13259
@arnaudbesnier
Copy link
Contributor

@codeclimate
Copy link

codeclimate bot commented Mar 3, 2021

Code Climate has analyzed commit c6c99d8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (60% is the threshold).

This pull request will bring the total coverage in the repository to 54.7%.

View more on Code Climate.

@ghusse ghusse changed the title fix(authentication): return better errors when a user is not authoriz… fix(authentication): return better errors when a user is not authorized to access a rendering Mar 3, 2021
@ghusse ghusse requested a review from Thenkei March 3, 2021 15:11
Copy link
Contributor

@Thenkei Thenkei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code review
✅ Automatic tests
✅ Manual tests

@ghusse ghusse merged commit c34dfc0 into master Mar 4, 2021
@ghusse ghusse deleted the fix/return-better-errors branch March 4, 2021 15:00
forest-bot added a commit that referenced this pull request Mar 4, 2021
## [8.0.1](v8.0.0...v8.0.1) (2021-03-04)

### Bug Fixes

* **authentication:** return better errors when a user is not authorized to access a rendering ([#660](#660)) ([c34dfc0](c34dfc0))
@forest-bot
Copy link
Member

🎉 This PR is included in version 8.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants