Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(authentication): redirect after first authentication step instead of returning the url #508

Merged
merged 1 commit into from
Oct 29, 2020
Merged

feat(authentication): redirect after first authentication step instead of returning the url #508

merged 1 commit into from
Oct 29, 2020

Conversation

ghusse
Copy link
Contributor

@ghusse ghusse commented Oct 28, 2020

…d of returning the url

Linked to CU-96whq6

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

@ghusse ghusse requested a review from DrRaider October 28, 2020 08:22
@forest-bot
Copy link
Member

Task linked: CU-96whq6 Story #2 - Initialise OpenId support on the express agent and the frontend

DrRaider
DrRaider approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@DrRaider DrRaider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title

@DrRaider DrRaider assigned ghusse and unassigned DrRaider Oct 29, 2020
Base automatically changed from fix/fix-request-analyzer to feat/authentication-with-openid-connect October 29, 2020 14:20
@ghusse ghusse changed the title feat(authentication): redirect after first authentication step instea… feat(authentication): redirect after first authentication step instead of returning the url Oct 29, 2020
feat(authentication): redirect after first authentication step instea…
1ce36e8 
…d of returning the url

Linked to CU-96whq6
@ghusse ghusse force-pushed the feat/redirect-after-first-step branch from 7088b1d to 1ce36e8 Compare October 29, 2020 14:21
@ghusse ghusse merged commit 3fe4f6f into feat/authentication-with-openid-connect Oct 29, 2020
@ghusse ghusse deleted the feat/redirect-after-first-step branch October 29, 2020 14:28
ghusse added a commit that referenced this pull request Nov 24, 2020
@ghusse
feat(authentication): redirect after first authentication step instea…
be4e1e4 
…d of returning the url (#508)
ghusse added a commit that referenced this pull request Nov 26, 2020
@ghusse
feat(authentication): redirect after first authentication step instea…
bc3fcf7 
…d of returning the url (#508)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrRaider DrRaider DrRaider approved these changes

Assignees

@ghusse ghusse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghusse @forest-bot @DrRaider