Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authentication): always return the token as a cookie, and never in the body #502

Conversation

ghusse
Copy link
Contributor

@ghusse ghusse commented Oct 20, 2020

Linked to CU-96whq6

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

@forest-bot
Copy link
Member

@ghusse ghusse marked this pull request as draft October 20, 2020 14:34
@ghusse ghusse marked this pull request as ready for review October 20, 2020 14:38
@ghusse ghusse force-pushed the feat/always-return-the-token-in-cookie branch from 8e472c9 to 077dc41 Compare October 21, 2020 15:08
@ghusse ghusse force-pushed the feat/new-route-callback-oidc branch from 20e2054 to e9f4f7c Compare October 26, 2020 08:05
Base automatically changed from feat/new-route-callback-oidc to feat/authentication-with-openid-connect October 26, 2020 08:07
@ghusse ghusse force-pushed the feat/always-return-the-token-in-cookie branch from 077dc41 to c612504 Compare October 26, 2020 08:17
@ghusse ghusse merged commit 26a0773 into feat/authentication-with-openid-connect Oct 26, 2020
@ghusse ghusse deleted the feat/always-return-the-token-in-cookie branch October 26, 2020 08:19
ghusse added a commit that referenced this pull request Nov 24, 2020
ghusse added a commit that referenced this pull request Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants