feat(smart-action): user can add dynamically field with hook on smart action form #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-moncel
changed the title
arnaud-moncel
force-pushed
the
feat/dynamic-smart-action-field
branch
2 times, most recently
from
cd74053
to
5777599
Compare
arnaud-moncel
force-pushed
the
chore/change-smart-action-hook-arguments
branch
from
1cb27ec
to
cc9a2a6
Compare
arnaud-moncel
force-pushed
the
feat/dynamic-smart-action-field
branch
from
5777599
to
c75e86e
Compare
arnaud-moncel
force-pushed
the
chore/change-smart-action-hook-arguments
branch
from
cc9a2a6
to
3d0857b
Compare
arnaud-moncel
force-pushed
the
feat/dynamic-smart-action-field
branch
2 times, most recently
from
252e775
to
f7e2dd1
Compare
jeffladiray
requested changes
Jun 2, 2021
| try { | ||
| smartActionFieldValidator.validateSmartActionFields(action, collection.name); | ||
| } catch (error) { | ||
| logger.error(error.message); |
There was a problem hiding this comment.
I've distinguish on the rails side warn (For invalid property that should still work) and error for things that might be broken. Maybe we should do the same here ?
There was a problem hiding this comment.
If we want to do that i will do the work inside an another PR
arnaud-moncel
force-pushed
the
chore/change-smart-action-hook-arguments
branch
from
63daef2
to
ce48f20
Compare
arnaud-moncel
force-pushed
the
feat/dynamic-smart-action-field
branch
from
d09709c
to
c320ef3
Compare
jeffladiray
previously approved these changes
Jun 3, 2021
arnaud-moncel
force-pushed
the
chore/change-smart-action-hook-arguments
branch
from
ce48f20
to
9816936
Compare
arnaud-moncel
force-pushed
the
feat/dynamic-smart-action-field
branch
from
c320ef3
to
737e5d6
Compare
… action form BREAKING CHANGE: change hook is no longer choosen by the field name, field need to have hook defined inside it definition by addin a props hook
arnaud-moncel
force-pushed
the
feat/dynamic-smart-action-field
branch
from
737e5d6
to
81f27a7
Compare
jeffladiray
approved these changes
Jun 7, 2021
forest-bot
added a commit
that referenced
this pull request
Jun 7, 2021
# [9.0.0-beta.5](v9.0.0-beta.4...v9.0.0-beta.5) (2021-06-07) ### Features * **smart-action:** user can add dynamically field with hook on smart action form ([#717](#717)) ([910df2b](910df2b)) ### BREAKING CHANGES * **smart-action:** change hook is no longer choosen by the field name, field need to have hook defined inside it definition by addin a props hook
|
🎉 This PR is included in version 9.0.0-beta.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Jul 19, 2021
# [9.0.0](v8.7.5...v9.0.0) (2021-07-19) ### Bug Fixes * handle composite primary key case when checking permissions for smart actions ([#756](#756)) ([30e8002](30e8002)) * **smart-action:** smart actions after trying to mitigate breaking change ([#754](#754)) ([c413992](c413992)) * remove breaking change on smart action middleware ([#739](#739)) ([b2a8f74](b2a8f74)) * update record getter usage in action route to use global scope ([#730](#730)) ([b92f158](b92f158)) ### Features * smart action hooks now have access to the http request ([#753](#753)) ([ea5cd59](ea5cd59)) * **security:** secure segments queries ([#747](#747)) ([23e8817](23e8817)) * **smart-action:** add changedField argument on hook function ([#716](#716)) ([709fe32](709fe32)) * **smart-action:** user can add dynamically field with hook on smart action form ([#717](#717)) ([910df2b](910df2b)) * feat(scopes)!: enforce scopes restrictions on a wider range of requests (#702) ([e36026e](e36026e)), closes [#702](#702) ### BREAKING CHANGES * record is no longer send to the hook midleware & values option on smart action is no longer supported * **smart-action:** change hook is no longer choosen by the field name, field need to have hook defined inside it definition by addin a props hook * **smart-action:** fields parameters on hook function is no longer a map of field, it is now an array. * the public API of the package has changed to include the parameters which are needed to evaluate scope filters. This includes PermissionMiddlewareCreator, all classes on the /exposed folder and most services.
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ShohanRahman
pushed a commit
that referenced
this pull request
Jan 25, 2022
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.5 to 2.8.9. **This update includes a security fix.** - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.5...v2.8.9) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
ShohanRahman
pushed a commit
that referenced
this pull request
Jan 25, 2022
## [8.0.14](ForestAdmin/forest-express-sequelize@v8.0.13...v8.0.14) (2021-08-25) ### Bug Fixes * **security:** patch hosted-git-info dependency vulnerability ([#717](ForestAdmin/forest-express-sequelize#717)) ([92ee9ed](ForestAdmin/forest-express-sequelize@92ee9ed))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: change hook is no longer choosen by the field name, field need to have hook defined inside it definition by adding a props hook
Pull Request checklist: