Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filters): nested aggregator weren't implemented #128

Merged
merged 1 commit into from
Apr 5, 2023
Merged

fix(filters): nested aggregator weren't implemented #128

merged 1 commit into from
Apr 5, 2023

Conversation

jbarreau
Copy link
Collaborator

@jbarreau jbarreau commented Apr 5, 2023 •
edited
Loading

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@forest-bot
Copy link
Member

Task linked: CU-860qf07we 🔥 P3 - Django agent raise an http 400 when filtering on a segment that have multiple criteria.

matthv
matthv approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@matthv matthv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbarreau jbarreau merged commit 4361849 into main Apr 5, 2023
@jbarreau jbarreau deleted the fix/nested_aggregator_in_filters branch April 5, 2023 10:26
forest-bot added a commit that referenced this pull request Apr 5, 2023
@forest-bot
chore(release): 1.4.7 [skip ci]
af63d0f 
## [1.4.7](v1.4.6...v1.4.7) (2023-04-05)

### Bug Fixes

* **filters:** nested aggregator weren't implemented ([#128](#128)) ([4361849](4361849))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.4.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthv matthv matthv approved these changes

@nicolasalexandre9 nicolasalexandre9 Awaiting requested review from nicolasalexandre9

Assignees

@matthv matthv

@nicolasalexandre9 nicolasalexandre9

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbarreau @forest-bot @matthv @nicolasalexandre9